Skip to content

Add bit timing class - #615

Merged
felixdivo merged 15 commits into
developfrom
bit-timing-class
Jun 23, 2019
Merged

felixdivo merged 15 commits into
developfrom
bit-timing-class

Conversation

@christiansandberg

@christiansandberg christiansandberg commented Jun 4, 2019 •

Copy link
Copy Markdown
Collaborator

A class for holding bit timing parameters. This is intended to replace the various bit timing arguments in some interfaces.

Part of #614.

@codecov

codecov Bot commented Jun 5, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #615 into develop will increase coverage by 0.07%.
The diff coverage is 66.9%.

@@             Coverage Diff             @@
##           develop     #615      +/-   ##
===========================================
+ Coverage    63.91%   63.98%   +0.07%     
===========================================
  Files           63       64       +1     
  Lines         5623     5765     +142     
===========================================
+ Hits          3594     3689      +95     
- Misses        2029     2076      +47

@christiansandberg christiansandberg changed the title [WIP] Add bit timing class Add bit timing class Jun 11, 2019
@christiansandberg christiansandberg self-assigned this Jun 11, 2019

@felixdivo felixdivo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is a good time to add typing information to the arguments & properties.

Comment thread can/bit_timing.py
Repository owner deleted a comment from codecov Bot Jun 23, 2019
@felixdivo felixdivo added this to the 4.0 Release milestone Jun 23, 2019
@felixdivo
felixdivo merged commit 9ab5e35 into develop Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants