Repository navigation
xDS: Ext proc client interceptor implement grfc updates - #13105
Open
kannanjgithub wants to merge 10 commits into
Open
kannanjgithub wants to merge 10 commits into
kannanjgithub wants to merge 10 commits into
Conversation
Only add RawMessageClientInterceptor to the interceptor chain in XdsNameResolver when either GRPC_EXPERIMENTAL_XDS_EXT_PROC_ON_CLIENT or GRPC_EXPERIMENTAL_XDS_EXT_PROC_ON_SERVER is true. This prevents RawMessageClientInterceptor from corrupting method descriptors and causing empty payloads on retry attempts for regular xDS channels. Fixes grpc#13010 TAG=agy CONV=56c87717-243d-4f12-af9e-c532e509892a
Update ext_proc client interceptor to treat OK termination without drain as non-OK status regardless of whether messages have started being sent to the ext_proc server, in accordance with the updated gRFC specification. TAG=agy CONV=581f86a6-097d-44a2-9d6e-6f9d2e83cbc0
…nt overflow Use LongMath.saturatedAdd when processing ServerWindowUpdate and replenishing sidestream windows to prevent integer overflow from turning windows negative. TAG=agy CONV=581f86a6-097d-44a2-9d6e-6f9d2e83cbc0
Reject xDS filter configuration if processing_mode is unset and fix checkstyle issues. TAG=agy CONV=581f86a6-097d-44a2-9d6e-6f9d2e83cbc0
TAG=agy CONV=581f86a6-097d-44a2-9d6e-6f9d2e83cbc0
…nt interceptor Updates ExternalProcessorClientInterceptor to enforce directional legal ordering and filter configuration rules according to the updated ext_proc gRFC specification: - Ensure legal ordering in client-to-server and server-to-client directions. - Fail with protocol error when ext_proc sends events the filter is not configured to send. - Allow ext_proc to insert messages before the filter has sent any. - Disallow events after end-of-stream. - Propagate protocol error cause as streamFailureCause in the RPC status. TAG=agy CONV=581f86a6-097d-44a2-9d6e-6f9d2e83cbc0
Add comprehensive tests for directional and configuration order validation in ExternalProcessorClientInterceptor. Fix order check so clientEndOfStreamReceived is evaluated before clientHeadersReceived (and trailers/EOS before headers). TAG=agy CONV=581f86a6-097d-44a2-9d6e-6f9d2e83cbc0
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the recent gRPC updates via 5 commits: