Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore: fix get RPO sample - #1207

Merged
cojenco merged 3 commits into
googleapis:mainfrom
tritone:rpo-sample-fix
Jan 4, 2024
Merged

chore: fix get RPO sample#1207
cojenco merged 3 commits into
googleapis:mainfrom
tritone:rpo-sample-fix

Conversation

@tritone

@tritone tritone commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

There was an extra line here that doesn't make sense. Fixing based on external user feedback.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/318488404 🦕

There was an extra line here that doesn't make sense. Fixing based
on external user feedback.
@tritone
tritone requested a review from a team as a code owner January 3, 2024 21:28
@tritone
tritone requested review from a team and vchudnov-g January 3, 2024 21:28
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Jan 3, 2024

@cojenco cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tritone for the fix! We'll also need to update to calling get_bucket() to actually make a metadata GET.

Comment thread samples/snippets/storage_get_rpo.py Outdated
Co-authored-by: cojenco <cathyo@google.com>
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 3, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 3, 2024

@cojenco cojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-running kokoro as the auth library fix just released, thank you!

@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 4, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 4, 2024
@cojenco
cojenco merged commit 243c5de into googleapis:main Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants