chore(spanner): Add benchwrapper. - #657
Conversation
zoercai
left a comment
There was a problem hiding this comment.
Please also get an approval from a Python reviewer before merging, my LGTM is only for what's been implemented, not the Python syntax/readability.
- Add script docstring with usage instructions. - Modify copyright in spanner.proto.
|
|
@ansh0l : This is done. Please merge it. Thank you! |
ansh0l
left a comment
There was a problem hiding this comment.
LGTM.
Minor: Please check if we can name these files (_pb2) better
benchmark/benchwrapper/proto/spanner_pb2.py
benchmark/benchwrapper/proto/spanner_pb2_grpc.py
@ansh0l : These were not written manually but were generated using grpc tool, and the so the files should not be renamed, or changed in any way. Thank you for merging the PR! |
This PR adds a Benchwrapper implementation for Python Spanner Client Library.
The benchwrapper implementation contains the following:
Checks: