You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR tries to reproduce the system test failure recorded in #969.
This PR fixes a group of compliance tests failures opened by flaky bot: #938 ~ #1002
After investigations it seems the rerun conditions of the compliance test, which work as regex match, did not catch the intended errors as the error messages' format has changed. Updated the strings so the compliance tests pass.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
@Linchin
Two things (not sure if you already know this or not):
if we are gonna change the noxfile.py for this testing, there may be some cases where the owlbot processor may run and revert all our changes to the noxfile.
To avoid this while we test the noxfile.py changes we can apply the owlbot:ignore label.
When it comes time to make changes to owlbot.py to create any needed updates in the noxfile.py, we have a local owlbot docker container that can simplify the testing to make sure owlbot.py is successful in creating all the edits we need.
Thank you for the reminder about owlbot! I definitely forgot about it, but lucked out as owlbot somehow did not run. I'll make sure owlbot.py is modified correctly in the final PR. I'll message you individually about the details to run the owlbot container.
Linchin
added
owlbot:run
Add this label to trigger the Owlbot post processor.
and removed
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: bigqueryIssues related to the googleapis/python-bigquery-sqlalchemy API.size: sPull request size is small.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to reproduce the system test failure recorded in #969.This PR fixes a group of compliance tests failures opened by flaky bot: #938 ~ #1002
After investigations it seems the rerun conditions of the compliance test, which work as regex match, did not catch the intended errors as the error messages' format has changed. Updated the strings so the compliance tests pass.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕