This repository was archived by the owner on Feb 23, 2026. It is now read-only.
chore(types): update mypy version - #768
Merged
Merged
Conversation
daniel-sanche
marked this pull request as draft
December 16, 2024 23:05
daniel-sanche
marked this pull request as ready for review
December 17, 2024 17:59
parthea
approved these changes
Jan 22, 2025
Contributor
|
Thanks @daniel-sanche ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix a couple typing issues that were causing recent versions of mypy to fail:
exceptions.py: error_info variable was reused for a list, and for an optional dict type. Broke the usages into separate variablesgrpc_helpers_async: addedGenericto_WrappedCallretry_unary: removed_Parguments fromtargettype annotation. We expect target to be afunctools.partial, and have no argumentsFixes #682