docs(sqlalchemy-spanner): centralize CONTRIBUTING.rst pointers - #18142
Draft
chalmerlowe wants to merge 2 commits into
Draft
docs(sqlalchemy-spanner): centralize CONTRIBUTING.rst pointers#18142chalmerlowe wants to merge 2 commits into
chalmerlowe wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the local markdown contribution guidelines with a restructured text file (packages/sqlalchemy-spanner/CONTRIBUTING.rst) that references the centralized Google Cloud Python monorepo contributing guide while retaining package-specific instructions for running tests. There are no review comments, so I have no feedback to provide.
…hours to prevent mid-test drops
chalmerlowe
force-pushed
the
feat/sqlalchemy-spanner-contributing
branch
from
August 19, 2026 13:23
14da3fa to
8c26694
Compare
chalmerlowe
added a commit
that referenced
this pull request
Aug 20, 2026
### Problem 1. Each package has a `CONTRIBUTING.rst` file and each file contained references to supported Python runtimes and specific dependency versions, etc. 2. The references to supported runtimes and needed dependencies needed to be updated every time we changed the install environment, which was unnecessary toil. ### Solution 1. Package-level `CONTRIBUTING.rst` files in handwritten libraries simply point to a centralized file in the repository root. 2. Removed all references from both the package-level mini-files and the repository's centralized file that used to spell out which Python runtime versions apply to this package. Instead we now point users to the `noxfile.py`, `setup.py`, and `pyproject.toml` as sources of truth for runtimes and other dependencies. ### Out of Scope/Future work 1. Update GAPIC templates to point at the central `CONTRIBUTING.rst` file. 2. Failing packages that are being processed independently: * #18041 * #18142 * #18157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR centralizes the contributing guidelines for sqlalchemy-spanner.
Blocked by: #17642