BigQuery: Run lint and black on samples/ directory #9081

Activity

1. tswast

   added

   api: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.

   type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.

   on Aug 22, 2019
2. plamut

   self-assigned this

   on Sep 16, 2019
3. plamut commented on Sep 17, 2019

   

   plamut

   on Sep 17, 2019

   Last edited by plamut

   Contributor

   More actions

   It appears that snippets are already linted. Black already runs on them, while the flake8 check needs to be extended to the docs/samples directory:

   diff --git a/bigquery/noxfile.py b/bigquery/noxfile.py
   index 37611a5ce29..fc44db1c120 100644
   --- a/bigquery/noxfile.py
   +++ b/bigquery/noxfile.py
   @@ -150,6 +150,7 @@ def lint(session):
        session.install("-e", ".")
        session.run("flake8", os.path.join("google", "cloud", "bigquery"))
        session.run("flake8", "tests")
   +    session.run("flake8", os.path.join("docs", "samples"))
        session.run("flake8", os.path.join("docs", "snippets.py"))
        session.run("black", "--check", *BLACK_PATHS)

   Noxfiles are auto-generated AFAIK, yes, thus the change needs to be made in the synthool repo (or wherever the files are generated).
4. tswast commented on Sep 23, 2019

   

   tswast

   on Sep 23, 2019

   ContributorAuthor

   More actions

   FYI: the noxfile.py template lives here: https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/python_library/noxfile.py.j2
5. tswast

   closed this as completedin #9277on Sep 26, 2019