Skip to content

fix: Fix media upload URI when API endpoint is overridden with client_opions.api_endpoint - #1992

Merged
parthea merged 3 commits into
googleapis:mainfrom
prkb:fix-media-upload-base-url
Dec 7, 2022
Merged

parthea merged 3 commits into
googleapis:mainfrom
prkb:fix-media-upload-base-url

Conversation

@prkb

@prkb prkb commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

This can happen when using Private Service Connect to access the APIs.

Fixes #1991

…ons.api_endpoint

This can happen when using Private Service Connect to access the APIs.
@prkb
prkb requested a review from a team December 5, 2022 22:14
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Dec 5, 2022
@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Dec 5, 2022 •

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@parthea parthea changed the title Fix media upload URI when API endpoint is overridden with client_opions.api_endpoint fix: Fix media upload URI when API endpoint is overridden with client_opions.api_endpoint Dec 6, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 6, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 6, 2022
@parthea
parthea merged commit d0f8a05 into googleapis:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Media upload URI does not respect overrides client_opions.api_endpoint

3 participants