Repository navigation
Reduce log spam by discovery.py by lowering logger level from info to debug/warn #781
Description
This line in discovery.py:
logger.info("URL being requested: GET %s", actual_url)
creates a lot of unncessary log spam. I don't think we need to know every time this code makes a request to Google, unless you're debugging. I use this library as part of HomeAssistant and my logs end up looking like (URLs sanitised):
2019-11-11 09:44:02 INFO (SyncWorker_6) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/discovery/v1/apis/calendar/v3/rest
2019-11-11 09:44:02 INFO (SyncWorker_6) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/calendar/v3/calendars/
2019-11-11 09:44:02 INFO (SyncWorker_2) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/discovery/v1/apis/calendar/v3/rest
2019-11-11 09:44:02 INFO (SyncWorker_2) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/calendar/v3/calendars/
2019-11-11 09:44:03 INFO (SyncWorker_9) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/discovery/v1/apis/calendar/v3/rest
2019-11-11 09:44:03 INFO (SyncWorker_9) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/calendar/v3/calendars/
2019-11-11 09:44:03 INFO (SyncWorker_6) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/discovery/v1/apis/calendar/v3/rest
2019-11-11 09:44:03 INFO (SyncWorker_6) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/calendar/v3/calendars/
2019-11-11 09:44:03 INFO (SyncWorker_6) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/discovery/v1/apis/calendar/v3/rest
2019-11-11 09:44:04 INFO (SyncWorker_6) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/calendar/v3/calendars/
2019-11-11 09:44:04 INFO (SyncWorker_3) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/discovery/v1/apis/calendar/v3/rest
2019-11-11 09:44:04 INFO (SyncWorker_3) [googleapiclient.discovery] URL being requested: GET https://www.googleapis.com/calendar/v3/calendars/
Wouldn't logger.debug be more appropratie?
Thanks.
Activity
[-]Reduce log spam in discovery.py by Lower logger level in to something else[/-][+]Reduce log spam in discovery.py by lowering logger level from info to debug/warn[/+][-]Reduce log spam in discovery.py by lowering logger level from info to debug/warn[/-][+]Reduce log spam by discovery.py by lowering logger level from info to debug/warn[/+]busunkim96 commentedon Nov 11, 2019
@timdonovanuk Feel free to send a PR if this is of interest!
timdonovanuk commentedon Dec 4, 2019
Thanks for this ..I'm not a developer more just get by hacking a bit of code occasionally so didn't know the correct way to submit PRs to this repo :)
feat: downgrade repetitive logging calls to debug
fix: downgrade repetitive logging calls to debug (#885)
parthea commentedon Dec 8, 2020
Hi @ timdonovanuk,
I'm going to close this issue as the issue was solved with PR #885.