Skip to content

chore: fix flaky system tests - #84

Merged
gcf-merge-on-green[bot] merged 2 commits into
mainfrom
flaky-tests
Oct 3, 2023
Merged

chore: fix flaky system tests#84
gcf-merge-on-green[bot] merged 2 commits into
mainfrom
flaky-tests

Conversation

@tswast

@tswast tswast commented Oct 3, 2023

Copy link
Copy Markdown
Collaborator
  • Remove a mutation that could affect subsequent tests.
  • Make error message from API more flexible.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

* Remove a mutation that could affect subsequent tests.
* Make error message from API more flexible.
@tswast
tswast requested review from a team and TrevorBergeron October 3, 2023 17:07
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 3, 2023
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 158c00c into main Oct 3, 2023
@gcf-merge-on-green
gcf-merge-on-green Bot deleted the flaky-tests branch October 3, 2023 17:50
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants