Skip to content

chore: clean up type errors in test_api_primitives - #696

Merged
tswast merged 3 commits into
mainfrom
ashleyxu-type-errors-api-primitives
May 17, 2024
Merged

chore: clean up type errors in test_api_primitives#696
tswast merged 3 commits into
mainfrom
ashleyxu-type-errors-api-primitives

Conversation

@ashleyxuu

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #340891292 🦕

@ashleyxuu
ashleyxuu requested review from a team and tswast May 16, 2024 20:53
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label May 16, 2024
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label May 16, 2024

@tswast tswast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast
tswast enabled auto-merge (squash) May 17, 2024 16:25
@tswast tswast changed the title fix: clean up type errors in test_api_primitives chore: clean up type errors in test_api_primitives May 17, 2024
@tswast
tswast merged commit ca284cc into main May 17, 2024
@tswast
tswast deleted the ashleyxu-type-errors-api-primitives branch May 17, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants