refactor: split read_gbq_table implementation into functions and move to separate module - #642
Merged
Merged
Conversation
…ve to separate module add todos
tswast
commented
Apr 30, 2024
chelsea-lin
approved these changes
Apr 30, 2024
| # the same assumption and use these columns as the total ordering keys. | ||
| is_index_unique = len(index_cols) != 0 | ||
| else: | ||
| is_index_unique = _check_index_uniqueness( |
Contributor
There was a problem hiding this comment.
This operation is also quiet expensive though.
Collaborator
Author
There was a problem hiding this comment.
Good point. I want to minimize any behavior changes in this PR. Filed b/338065601 to follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕