Use a method to handle results without sucess data#1602
Closed
Conversation
Contributor
|
I believe that another way to fix this would be to patch the data when reading it from the query history (see https://github.com/github/vscode-codeql/blob/main/extensions/ql-vscode/src/query-serialization.ts#L29). That way we don't have to deal with the complexity further up. |
aeisenberg
reviewed
Oct 14, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
Minor suggestion and then good to go.
| if(this.successful !== undefined) { | ||
| return this.successful; | ||
| } else { | ||
| return this.result.resultType == legacyMessages.QueryResultType.SUCCESS; |
Contributor
|
Actually, I like @charis's idea better. |
Contributor
|
Problem is different from the solution here. There was a typo fix that was merged right around the same time as this and changed the serialization code. #1594 I am going to close this PR and work on a different fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug when loading old results where we think they weren't successful. This is a bit awkward due to having to create a method as the old getter would no longer work.
Checklist
ready-for-doc-reviewlabel there.