Conversation
This will include the Codicons inside the webview bundle, reducing the number of files that need to be loaded and the resource roots that need to be included.
5 tasks
aeisenberg
reviewed
Aug 31, 2022
Contributor
aeisenberg
left a comment
There was a problem hiding this comment.
With this change, does this mean that we can remove the references to codicons when generating the webview? LIke here
and here ?
Member
Author
|
Thanks for noticing, those changes probably got lost when I merged in |
charisk
approved these changes
Sep 1, 2022
Contributor
charisk
left a comment
There was a problem hiding this comment.
Thanks for tidying this up! Just a couple of questions/comments.
charisk
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will include the Codicons inside the webview bundle, reducing the number of files that need to be loaded and the resource roots that need to be included.
The only place where a codicon is currently used is in the repository search bar for MRVA results.
Checklist
ready-for-doc-reviewlabel there.