MRVA: Generate markdown summary for query with raw results#1318
Merged
shati-patel merged 4 commits intomainfrom Apr 27, 2022
Merged
MRVA: Generate markdown summary for query with raw results#1318shati-patel merged 4 commits intomainfrom
shati-patel merged 4 commits intomainfrom
Conversation
630d962 to
2201572
Compare
charisk
reviewed
Apr 26, 2022
Contributor
charisk
left a comment
There was a problem hiding this comment.
Sorry, ran out of time, will look at this more tomorrow!
| /** | ||
| * Returns the number of (raw + interpreted) results for an analysis. | ||
| */ | ||
| export const getAnalysisResultCount = (analysisResults: AnalysisResults): number => { |
Contributor
There was a problem hiding this comment.
Hmm this function doesn't really have much to do with SARIF so it feels like it doesn't belong to sarif.utils.ts. Should we move it to analysis-result.ts? (Or anywhere else you think is appropriate)
| for (const analysisResult of analysesResults) { | ||
| if (analysisResult.interpretedResults.length === 0) { | ||
| // TODO: We'll add support for non-interpreted results later. | ||
| if (analysisResult.interpretedResults.length === 0 && !analysisResult.rawResults) { |
Contributor
There was a problem hiding this comment.
Is this really a check for 0 results? If so, we can move L23 to L17 and then do
if (resultsCount === 0) {
continue;
}
Contributor
Author
There was a problem hiding this comment.
Thank you, good point! 🙈
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step towards rendering markdown for non-interpreted results (see internal issue).
This PR adds new test data and creates a summary file (example here) 🖼️
I haven't yet added support for the rendering the actual results table (I'll do that in a follow-up PR 🔜 )
Checklist
N/A - internal only 🔐
ready-for-doc-reviewlabel there.