Add better error messages for partial failing variant analysis#1295
Merged
aeisenberg merged 3 commits intomainfrom Apr 20, 2022
Merged
Add better error messages for partial failing variant analysis#1295aeisenberg merged 3 commits intomainfrom
aeisenberg merged 3 commits intomainfrom
Conversation
Two scenarios handled: 1. no database for existing repo 2. repo does not exits (or no access rights for current user) In either case, an error message is sent to the logs, with a notificaiton in a popup.
shati-patel
reviewed
Apr 14, 2022
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Thanks! Nice to tell the user when we skip repositories 😎
A few comments (and some failing PR checks) 📝
Also, change text slightly.
shati-patel
approved these changes
Apr 19, 2022
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Thanks! Just some tiny optional comments 🥇
| import { expect } from 'chai'; | ||
| import { parseResponse } from '../../../remote-queries/run-remote-query'; | ||
|
|
||
| describe('run-remote-queries', () => { |
Contributor
There was a problem hiding this comment.
Thanks for adding the test 🙌🏽
Very minor - could we change the name of this test (and the file name itself) to run-remote-query? Just for consistency with the name of the file we're testing 😸
| it('should parse a response with invalid repos and repos w/o databases', () => { | ||
| const result = parseResponse('org', 'name', { | ||
| workflow_run_id: 123, | ||
| repositories_queried: ['a/b', 'c/d'], |
Contributor
There was a problem hiding this comment.
Do we also want to test the case where no repositories succeeded?
And rename test file.
Contributor
Author
|
Comments addressed. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two scenarios handled:
In either case, an error message is sent to the logs, with a notificaiton
in a popup.
Log message looks like this: