Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the npm publish GitHub Actions workflow to support an OIDC-based publishing flow (enabling npm provenance), aligning with the OIDC migration effort referenced in the PR description.
Changes:
- Grants the workflow
id-token: writepermission to enable OIDC token issuance. - Switches the publish step from using
NODE_AUTH_TOKENtonpm publish --provenance(trusted publishing / provenance flow).
Show a summary per file
| File | Description |
|---|---|
.github/workflows/publish.yaml |
Enables OIDC (id-token: write) and updates npm publish to use provenance without an npm token secret. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309
OIDC migration - quick question, does this publish to an npm package? If so, can you provide me the link?