Skip to content

feat: include submitter info.#35

Merged
dgreif merged 1 commit intogithub:mainfrom
strfx:feat/include-submitter-info
May 6, 2024
Merged

feat: include submitter info.#35
dgreif merged 1 commit intogithub:mainfrom
strfx:feat/include-submitter-info

Conversation

@strfx
Copy link
Copy Markdown
Contributor

@strfx strfx commented May 2, 2024

Buttons allow you to overwrite a forms method with the formmethod attribute. buildRequest now incorporates submitter info when determining the request method. SubmitEvent interface is now generally supported.

I also browsed #16. In comparison to then, submitter parameter to FormData is now available. Do you reconsider merging #16 or any PR that would implement it? :-)

@strfx strfx requested a review from a team as a code owner May 2, 2024 08:46
@strfx strfx requested a review from manuelpuyol May 2, 2024 08:46
Buttons allow you to overwrite a forms `method` with the `formmethod`
attribute. `buildRequest` now incorporates submitter info when
determining the submit requests method.
@strfx strfx force-pushed the feat/include-submitter-info branch from bc23bf2 to 23e9722 Compare May 2, 2024 08:48
Copy link
Copy Markdown
Contributor

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great addition!

@dgreif dgreif merged commit 697e317 into github:main May 6, 2024
@strfx
Copy link
Copy Markdown
Contributor Author

strfx commented May 7, 2024

awesome, thanks @dgreif ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants