Open
Conversation
Removed npm whoami command from publish workflow.
There was a problem hiding this comment.
Pull request overview
Simplifies the GitHub Actions npm publish workflow triggered on release creation by removing the npm whoami check and adjusting the publish step.
Changes:
- Removed
npm whoamifrom the publish job. - Updated the publish step to run
npm --ignore-scripts publish --provenanceas a single command (but also removed the previous auth env wiring).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish.yml | Simplifies the npm publish step in the release-created workflow. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:27
- PR description says this change only removes
npm whoami, but the diff also removes theNODE_AUTH_TOKENenv wiring for the publish step. Please update the description to reflect the behavioral change, or restore the env if it was removed unintentionally.
- run: npm --ignore-scripts publish --provenance
- Files reviewed: 2/2 changed files
- Comments generated: 1
| - run: npm whoami; npm --ignore-scripts publish --provenance | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{secrets.npm_token}} | ||
| - run: npm --ignore-scripts publish --provenance |
bteng22
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309
Removed npm whoami command from publish workflow.