Update Node.js version and permissions in publish.yml#37
Open
Update Node.js version and permissions in publish.yml#37
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the release publishing workflow to support the OIDC/provenance-based publishing flow and modernize the Node.js runtime used during publishes.
Changes:
- Add explicit job permissions (including
id-token: write) to enable OIDC-based provenance. - Upgrade the publish jobs to Node.js 20.
- Switch publish commands to use
npm publish --provenanceand remove long-lived npm token usage from the workflow.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish.yml | Updates Node version, job permissions, and publish steps to support OIDC/provenance publishing. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:36
- Same as above:
actions/checkout@v3/actions/setup-node@v3are on an older GitHub Actions runtime; bumping to v4 reduces the risk of the publish workflow breaking due to action runtime deprecations.
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
- Files reviewed: 1/1 changed files
- Comments generated: 2
| - run: npm whoami; npm --ignore-scripts publish | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - run: npm --ignore-scripts publish --provenance |
Comment on lines
14
to
16
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/github/web-systems/issues/4309
OIDC migration