Make sure all anchors are created for RST links#1536
Merged
jmeridth merged 2 commits intogithub:masterfrom Sep 4, 2024
Merged
Conversation
94ff91c to
a78c9a7
Compare
Contributor
Author
|
Is there actually any interest in contributions to this repository? If not, maybe that should be explicitly mentioned... https://github.com/github/markup/blob/master/CONTRIBUTING.md seemed to indicate to me that contributions are wanted... |
|
Stale pull request message |
jmeridth
approved these changes
Sep 4, 2024
Contributor
jmeridth
left a comment
There was a problem hiding this comment.
@felixfontein I tested your change locally. Thank you for the contribution. It is greatly appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1535.
Running the script on the source of https://gist.github.com/felixfontein/5ec5ad555ba6cdb293beb04c83280c90 produces:
Here both expected anchors (the auto-generated one from the section title, and the one from the label) are created.