Skip to content

Dev-where branch : Add a feature to filter the data you need #718

Open
cenkore wants to merge 17 commits intogithub:masterfrom
cenkore:dev-where
Open

Dev-where branch : Add a feature to filter the data you need #718
cenkore wants to merge 17 commits intogithub:masterfrom
cenkore:dev-where

Conversation

@cenkore
Copy link
Copy Markdown

@cenkore cenkore commented Feb 26, 2019

The main usage scenarios are as follows:

  1. If you need to clean up some of the data before you doing the gh-ost release, it can release with -where-reserve-clause directly and you don't need to do a clean up first.

  2. If you just wanna clear a lot of data, especially for the amount of cleaning is greater than the amount of retention, it can avoid DELETE + OPTIMIZE operation.

add 2 flags:

  • where-reserve-clause: used for only copy where clause stmt values
  • force-query-migration-range-values-on-master: if you use where-reserve-clause flag, by default, will query initial migration range values with corresponding where clause stmt on slave. Also you can specify this flag to true , it will query on master and not care where clause stmt like usual and the where clause stmt would be used at copy rows to gho table.

modify 1 flag
-alter: you can specify Noop if you just wanna do a table slimming and not change the table structure

@cenkore
Copy link
Copy Markdown
Author

cenkore commented Mar 19, 2019

@shlomi-noach can you take a look ? were really stuck here .

@sierra2019
Copy link
Copy Markdown

what needs to be done

@dikang123
Copy link
Copy Markdown

excellent feature, when will this feature merge into the trunk?

@sierra2019
Copy link
Copy Markdown

nobody filled me in on what is going on so i am confused

@sierra2019
Copy link
Copy Markdown

sierra2019 commented Apr 18, 2019 via email

sierra2019
sierra2019 previously approved these changes Apr 25, 2019
Comment thread build.sh
echo "Building ${osname} binary"
export GOOS
export GOARCH

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtc.gho-stjavascript.

@sierra2019
Copy link
Copy Markdown

would this work

@zpatten
Copy link
Copy Markdown

zpatten commented May 6, 2019

We would like to use gh-ost, however we need this functionality; can we expect this to be merged anytime soon?

@cenkore
Copy link
Copy Markdown
Author

cenkore commented May 9, 2019

would this work

What needs to be done for this PR ? It's stuck here with "Some checks haven’t completed yet" , and I dont know how to fix it.

@zpatten
Copy link
Copy Markdown

zpatten commented May 9, 2019

@cenkore Looks like the CI pipeline possibly stalled out there. Maybe rebase with the latest master and push the branch up again to kick the CI bits.

@cenkore
Copy link
Copy Markdown
Author

cenkore commented May 10, 2019

@cenkore Looks like the CI pipeline possibly stalled out there. Maybe rebase with the latest master and push the branch up again to kick the CI bits.

@zpatten thanks for your advice , I will try again later.

@cenkore
Copy link
Copy Markdown
Author

cenkore commented May 10, 2019

I merged latest master into my branch, still stuck here 😔
Any details or build logs ?

@welyss
Copy link
Copy Markdown

welyss commented Jul 10, 2024

Nice feature, hope to be released!

@dontstopbelieveing
Copy link
Copy Markdown
Contributor

Hello :)
This would be a very much needed feature. Are there plans to merge this ?

@zzfox
Copy link
Copy Markdown

zzfox commented Sep 17, 2025

Now is 2025/09/17, what is the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants