Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…flow - Create .github/skills/jqschema/SKILL.md with tools, steps, and full documentation - Delete .github/workflows/shared/jqschema.md - Update all .github/workflows/*.md files to import ../skills/jqschema/SKILL.md - Update all .github/workflows/shared/*.md files to import ../skills/jqschema/SKILL.md - Update documentation references in shared workflows - Update pkg/cli/workflows/shared/jqschema.md with actual skill content - Recompile all lock files Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot the skill folder should contain the jqschema.sh file and remove the code that generates the jqschema.sh on the fly |
Instead of generating jqschema.sh inline via a heredoc, the skill now stores jqschema.sh as a real file at .github/skills/jqschema/jqschema.sh and the setup step copies it to /tmp/gh-aw/jqschema.sh at runtime. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done. Added |
There was a problem hiding this comment.
Pull request overview
Converts the jqschema utility from a shared workflow include into a first-class “skill”, and updates workflow imports and compiled lockfiles to reference the new skill location.
Changes:
- Added
.github/skills/jqschema/withSKILL.mdand a standalonejqschema.sh, and updated setup to copy the script from the repo instead of generating it inline. - Updated workflow imports to use
../skills/jqschema/SKILL.mdand regenerated affected.lock.ymlfiles to runtime-import.github/skills/jqschema/SKILL.md. - Updated the CLI workflow fixture
pkg/cli/workflows/shared/jqschema.mdto mirror the skill content.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/workflows/shared/jqschema.md | Replaces placeholder with skill-like frontmatter, setup step, and usage docs. |
| .github/workflows/stale-repo-identifier.md | Updates import from shared/jqschema.md to skill path. |
| .github/workflows/stale-repo-identifier.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/smoke-codex.lock.yml | Lockfile churn from regeneration (config heredocs, etc.). |
| .github/workflows/smoke-call-workflow.lock.yml | Lockfile churn from regeneration (config heredocs, etc.). |
| .github/workflows/shared/weekly-issues-data-fetch.md | Updates docs text to reference the jqschema skill. |
| .github/workflows/shared/issues-data-fetch.md | Updates docs text to reference the jqschema skill. |
| .github/workflows/shared/discussions-data-fetch.md | Updates docs text to reference the jqschema skill. |
| .github/workflows/shared/copilot-session-data-fetch.md | Updates references/import to new skill path and wording. |
| .github/workflows/shared/copilot-pr-data-fetch.md | Updates docs/example import to new skill path and wording. |
| .github/workflows/shared/copilot-pr-analysis-base.md | Updates import to new skill path. |
| .github/workflows/shared/ci-data-analysis.md | Updates import to new skill path. |
| .github/workflows/scout.md | Updates import to new skill path. |
| .github/workflows/scout.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/schema-feature-coverage.lock.yml | Lockfile churn from regeneration (config heredocs, etc.). |
| .github/workflows/safe-output-health.md | Updates import to new skill path. |
| .github/workflows/safe-output-health.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/prompt-clustering-analysis.md | Updates import to new skill path. |
| .github/workflows/prompt-clustering-analysis.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/org-health-report.md | Updates import to new skill path. |
| .github/workflows/org-health-report.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/issue-arborist.md | Updates import to new skill path. |
| .github/workflows/duplicate-code-detector.lock.yml | Lockfile churn from regeneration (config heredocs, etc.). |
| .github/workflows/discussion-task-miner.md | Updates import to new skill path. |
| .github/workflows/discussion-task-miner.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/deep-report.md | Updates import to new skill path. |
| .github/workflows/deep-report.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/daily-safe-output-optimizer.md | Updates import to new skill path. |
| .github/workflows/daily-safe-output-optimizer.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/daily-observability-report.lock.yml | Lockfile churn from regeneration (config heredocs, etc.). |
| .github/workflows/daily-news.md | Updates import to new skill path. |
| .github/workflows/daily-news.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/daily-issues-report.md | Updates import to new skill path. |
| .github/workflows/daily-issues-report.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/daily-fact.lock.yml | Lockfile churn from regeneration (config heredocs, etc.). |
| .github/workflows/daily-cache-strategy-analyzer.lock.yml | Lockfile churn from regeneration (config heredocs, etc.). |
| .github/workflows/copilot-session-insights.md | Updates import to new skill path. |
| .github/workflows/copilot-session-insights.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/copilot-pr-prompt-analysis.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/copilot-pr-nlp-analysis.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/copilot-pr-merged-report.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/copilot-opt.md | Updates import to new skill path. |
| .github/workflows/copilot-opt.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/copilot-agent-analysis.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/cloclo.md | Updates import to new skill path. |
| .github/workflows/cloclo.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/cli-version-checker.md | Updates import to new skill path. |
| .github/workflows/cli-version-checker.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/ci-coach.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/changeset.md | Updates import to new skill path. |
| .github/workflows/changeset.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/audit-workflows.md | Updates import to new skill path. |
| .github/workflows/audit-workflows.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/workflows/api-consumption-report.md | Updates import to new skill path. |
| .github/workflows/api-consumption-report.lock.yml | Regenerated to runtime-import skill and copy script from repo file. |
| .github/skills/jqschema/SKILL.md | New skill definition; copies jqschema.sh into /tmp/gh-aw/. |
| .github/skills/jqschema/jqschema.sh | New standalone script implementing the jq schema walker. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
.github/workflows/shared/copilot-session-data-fetch.md:217
- The documentation here contradicts the header note about BFS import ordering. This file states transitive imports may not have their steps executed before the parent import’s steps, but this note claims the compiler ensures dependencies are set up “in the correct order”. Since this component’s steps invoke
/tmp/gh-aw/jqschema.sh, readers may incorrectly assume importing this file alone is sufficient. Update/remove this note to avoid implying transitive import ordering guarantees that don’t exist.
- Files reviewed: 58/58 changed files
- Comments generated: 1
| imports: | ||
| - shared/jqschema.md | ||
| - ../skills/jqschema/SKILL.md |
|
@copilot merge main and recompile |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ema-to-skill # Conflicts: # .github/workflows/daily-cache-strategy-analyzer.lock.yml # .github/workflows/daily-fact.lock.yml # .github/workflows/daily-observability-report.lock.yml # .github/workflows/duplicate-code-detector.lock.yml # .github/workflows/schema-feature-coverage.lock.yml # .github/workflows/smoke-call-workflow.lock.yml # .github/workflows/smoke-codex.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done — merged main and recompiled all lock files. |
Moves
jqschema.shout of.github/workflows/shared/and into.github/skills/jqschema/, aligning it with the skills pattern used by other workflow utilities.Changes
.github/skills/jqschema/contains two files:jqschema.sh— the script as a standalone file in the repo (no longer generated inline via heredoc)SKILL.md— carries thetools:allowlist,steps:setup (copiesjqschema.shfrom$GITHUB_WORKSPACEto/tmp/gh-aw/jqschema.sh), and usage docs.github/workflows/shared/jqschema.md.github/workflows/*.mdand.github/workflows/shared/*.md):pkg/cli/workflows/shared/jqschema.mdreplaced its stub with the real skill content.github/skills/jqschema/SKILL.md; compiled setup step copies from the repo file instead of generating inline