Fix searchInput UI when there are no search results - #7608
Conversation
| # LOCALIZATION NOTE (editor.noResults): Editor Search bar message | ||
| # for when no results found. | ||
| editor.noResults=No results | ||
| editor.noResults=No results found |
There was a problem hiding this comment.
This type of changes requires a new string ID
https://developer.mozilla.org/en-US/docs/Making_String_Changes
Make sure to also update the reference in the comment
There was a problem hiding this comment.
If your changes are relevant only for English — for example, to correct a typographical error or to make letter case consistent — then there is generally no need to update the entity name.
I just appended "found" keyword which doesn't change the meaning still if it requires new string ID let me know. @flodolo
There was a problem hiding this comment.
It might not change the general meaning, but the resulting translations will be likely different. I'd still change the ID, if it's important to update the string for en-US
There was a problem hiding this comment.
Add new string with id : "editor.noResultsFound" and value : "No results found"
…n necessary files
| # LOCALIZATION NOTE (editor.noResults): Editor Search bar message | ||
| # for when no results found. | ||
| editor.noResults=No results found | ||
| editor.noResults=No results |
There was a problem hiding this comment.
Is this string still used after your changes? If it isn't, you should remove it from the file entirely, and update the localization note to reference the new string instead.
…he localization note
flodolo
left a comment
There was a problem hiding this comment.
Thanks, l10n bits look good. Leaving to devs the actual review ;-)
|
|
||
| .search-field input.empty { | ||
| color: var(--theme-highlight-orange); | ||
| color: #737373; |
There was a problem hiding this comment.
is there a variable color that we could use? something that starts with --theme-
https://developer.mozilla.org/en-US/docs/Tools/DevToolsColors
There was a problem hiding this comment.
Yes I have made the changes. @jasonLaster
|
Added a small change to make the result text not selectable |
Fixes #7325
Summary of Changes
Test Plan
Search for any random keyword in any file of a project, which is most likely to be not found .
Screenshots