This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[Flow] Upgrade to 68 - #6501
Merged
Merged
Conversation
Merged
darkwing
reviewed
Jun 12, 2018
| case "MOVE_TAB": | ||
| return state.merge({ | ||
| tabs: updateTabList({ sources: state }, action.url, action.tabIndex) | ||
| tabs: updateTabList(state.sources.tabs, action.url, action.tabIndex) |
Contributor
There was a problem hiding this comment.
Would it be easier if we did state.sources.tabs || []?
Contributor
Author
There was a problem hiding this comment.
hmm, what's the benefit of that?
Contributor
There was a problem hiding this comment.
I (thought I) saw a circle failure due to updateTabList returning undefined
Contributor
Author
There was a problem hiding this comment.
got it. We might be able to add a sensible default in initializer
Contributor
|
👀 looking at this and then the 70 PR now. |
wldcordeiro
reviewed
Jun 13, 2018
| function updateTabList(state: OuterState, url: ?string, tabIndex?: number) { | ||
| let tabs = state.sources.tabs; | ||
|
|
||
| function updateTabList(tabs: TabList, url: ?string, tabIndex?: number) { |
Contributor
There was a problem hiding this comment.
Failures because tabs is undefined and we try to indexOf it.
jasonLaster
force-pushed
the
flow-68
branch
2 times, most recently
from
June 13, 2018 16:46
7e5eeba to
47523f3
Compare
wldcordeiro
approved these changes
Jun 16, 2018
jasonLaster
added a commit
that referenced
this pull request
Jun 28, 2018
jasonLaster
added a commit
that referenced
this pull request
Jun 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #5687