This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[SourceTree] Don't blur when tree is no longer focused - #6488
Merged
Conversation
jasonLaster
approved these changes
Jun 19, 2018
Contributor
|
Nice |
wldcordeiro
reviewed
Jun 19, 2018
| style: PropTypes.object | ||
| style: PropTypes.object, | ||
| // Prevents blur when Tree loses focus | ||
| preventBlur: PropTypes.bool |
Contributor
There was a problem hiding this comment.
Maybe add a default prop value for this? You're just checking the negation so not having one should be fine but it's good to have a default.
jasonLaster
pushed a commit
that referenced
this pull request
Jul 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One thing that bugs me is when I click an item in the source tree and then navigate over to the editor, the focused source's highlight disappears. IMO it shouldn't -- the focused file should always be highlighted in the tree.