Switched getExtraProps to use findClosestFunction to get the component name.

[mmcote]

Summary of Changes

• Changed getExtraProps to use findClosestFunction, which has now been changed to findClosestofSymbolDeclaration to find the name of the component even when in production code.

Screenshots

Before

After

[jasonLaster]

Looks pretty good!

[jasonLaster]

nit: findClosestofSymbol is smaller :)

[jasonLaster]

we can move this to findClosestofSymbol

[darkwing]

Wow, this looks slick @mmcote! Nice work!

So I'm trying to test this on a React app (debugger.html) and I'm not seeing the t or App panes; any idea what I could be doing wrong?

Thanks!

[mmcote]

Hey @darkwing, I'm not a hundred percent sure why, and I can look into it, but Jason found a similar issue when debugging the debugger that the react component pane wasn't being triggered when in a component. He suggested switching to a isReactComponent that looks if the class extends Component, PureComponent, etc. Looking through the code I found isReactComponent that does this in the workers/parser/framework.js, more specifically it does this in the method it calls extendsReactComponent. Switching all the isReactComponent's currently being used (which just search for the property _reactInternalInstance or _reactInternalFiber), to this extendsReactComponent seems to fix the issue that Jason was seeing when debugging the debugger. Hopefully this will do the trick for yours as well.

I will push this once I look into the other calls of the new isReactComponent and if they are needed in this case. As currently the new isReactComponent in workers/parser/framework.js also checks if it importsReact or requiresReact which doesn't seem to return true when testing Jason's case.

[jasonLaster]

We can look into the debugger case separately... This logic works well and the code reads well.