Speedup quick open - #5166
Conversation
|
Awesome speed increase! Based on search engine behavior it feels like we can limit the number of results even more. E.g. a result on position 41 only gets 0.07% of clicks, so going up to 50 seems feasible as a user will have refined his search by that time anyway (or at least 993 in 1000 users will have). |
It's a nice addition, one suggestion though would be to do an |
| const [baseQuery] = query.split(":"); | ||
| const results = filter(this.props.sources, baseQuery, { key: "value" }); | ||
| const results = filter(this.props.sources, baseQuery, { | ||
| key: "value", |
There was a problem hiding this comment.
Realized we always use the same options maybe putting them as a constant at the top of the file and reusing instead of a new object each time.
There was a problem hiding this comment.
yeah - i can give that a go
was thinking that too |
|
what do you think of hiding the results count... i dont think other editors show it? we can then be more aggressive about limiting results |
I like that idea. I just checked the Atom panel and it doesn't show any count it just shows an error "Project is empty" message. |
7c4f706 to
fceff41
Compare
fceff41 to
ec19296
Compare
Associated Issue: #5085 #4996
Summary of Changes
Slow version
Fast version