Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

[Outline] Style list - #4851

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
arthur801031:outline_style
Jan 11, 2018
Merged

[Outline] Style list#4851
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
arthur801031:outline_style

Conversation

@arthur801031

Copy link
Copy Markdown
Contributor

Associated Issue: #4792

Summary of Changes

  • Fix hover background's width by removing padding-left and padding-right from .outline-list

@codehag

codehag commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

Thanks for the PR! can you add some screen shots?

@arthur801031

Copy link
Copy Markdown
Contributor Author

No problem :)

screen shot 2017-12-03 at 8 53 33 am

screen shot 2017-12-03 at 8 52 33 am

@darkwing

Copy link
Copy Markdown
Contributor

Hey @arthur801031! I'm still seeing the hover cutoff issue when I scroll:

longandscrolled

I'll experiment to see if I can find a way around this.

@jasonLaster

Copy link
Copy Markdown
Contributor

Hey @arthur801031 do you have time to take a look at this?

@jasonLaster

Copy link
Copy Markdown
Contributor

rebased!

@arthur801031

arthur801031 commented Dec 21, 2017

Copy link
Copy Markdown
Contributor Author

Hi @darkwing ! could you let me know how to reproduce this issue? When I was testing it, I didn’t see it 😅

screen shot 2017-12-21 at 9 32 09 pm

Hi @jasonLaster ! I’m sorry for the delay. I’ll take a look at this today. Thank you! 🙏

@davide-dc-dev

Copy link
Copy Markdown
Contributor

Hi @arthur801031 ! I reproduce the issue shrinking the outline window

outlinebug

I think if you add in .outline-list__element margin-right: -xy px; it should be ok

@codehag

codehag commented Jan 8, 2018

Copy link
Copy Markdown
Contributor

@arthur801031 hello! do you need any help moving this forward?

@darkwing

Copy link
Copy Markdown
Contributor

Soooo.. I took some time trying to figure out how to avoid the weird overflow / hover cutoff issue and I found a hacky way to fix it:

.outline-list {
  /* width: 100%; */
  min-width: 100%;
  display: inline-table;
}

display: inline-table seems...kinda gross. Looking at the sources tree, the same hover cutoff issue exists. I think we should punt on that part of the original issue, merge this, and investigate the other fix separately. Thoughts @jasonLaster ?

@jasonLaster

Copy link
Copy Markdown
Contributor

Lets do it!

@jasonLaster
jasonLaster merged commit da80d03 into firefox-devtools:master Jan 11, 2018
jasonLaster pushed a commit that referenced this pull request Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants