Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

refactor loadSourceText - #3853

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
codehag:feature/refactor-loadsourcetext
Sep 1, 2017
Merged

refactor loadSourceText#3853
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
codehag:feature/refactor-loadsourcetext

Conversation

@codehag

@codehag codehag commented Sep 1, 2017

Copy link
Copy Markdown
Contributor

load source text has been moved into its own file

@jasonLaster jasonLaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@codecov

codecov Bot commented Sep 1, 2017

Copy link
Copy Markdown

Codecov Report

Merging #3853 into master will increase coverage by <.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3853      +/-   ##
==========================================
+ Coverage   55.06%   55.06%   +<.01%     
==========================================
  Files         126      127       +1     
  Lines        4894     4892       -2     
  Branches     1014     1014              
==========================================
- Hits         2695     2694       -1     
+ Misses       2199     2198       -1
Impacted Files Coverage Δ
src/actions/sources.js 79.03% <ø> (-1.26%) ⬇️
src/actions/sources/loadSourceText.js 92.3% <92.3%> (ø)
src/utils/parser/getEmptyLines.js 89.47% <0%> (-0.53%) ⬇️
src/components/Editor/Preview/Popup.js 6.15% <0%> (ø) ⬆️
src/components/SecondaryPanes/Frames/Group.js 73.52% <0%> (ø) ⬆️
src/components/SecondaryPanes/Frames/Frame.js 44.44% <0%> (ø) ⬆️
src/components/shared/Modal.js 86.66% <0%> (ø) ⬆️
src/components/SecondaryPanes/Frames/WhyPaused.js 91.3% <0%> (ø) ⬆️
src/components/Editor/CallSites.js 1.05% <0%> (ø) ⬆️
src/components/shared/ResultList.js 100% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1a61c...7b5abba. Read the comment docs.

@jasonLaster
jasonLaster merged commit ff2bd33 into firefox-devtools:master Sep 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants