This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Persist scopes - #2064
Merged
Merged
Conversation
bomsy
commented
Feb 21, 2017
|
|
||
| const children = makeNodesForProperties(loadedProps, item.path); | ||
| this.actorCache[actor] = children; | ||
| this.actors[key] = children; |
Contributor
Author
There was a problem hiding this comment.
This was the nightmare bug!! :)
Codecov Report
@@ Coverage Diff @@
## master #2064 +/- ##
======================================
Coverage 0% 0%
======================================
Files 40 40
Lines 696 696
======================================
Misses 696 696Continue to review full report at Codecov.
|
* add expanded cache * add basic caching for the scopes across loads * add missed property
jasonLaster
force-pushed
the
persist-scopes
branch
from
February 22, 2017 19:28
2215c30 to
e46641c
Compare
jasonLaster
approved these changes
Feb 22, 2017
jasonLaster
left a comment
Contributor
There was a problem hiding this comment.
馃憤
Lets add some tests in a follow up PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #1617
Summary of Changes
actorsandexpandedstates acrossObjectInspectorcomponent mounts.getChildrenfunction. The loaded children were cached against theactorrather than thekey. ( Finding this was the nightmare) :)Test Plan
Screenshots/Videos (OPTIONAL)