Skip to content

Removed CHANGELOG file - #319

Merged
hiranya911 merged 1 commit into
masterfrom
hkj-remove-changelog
Oct 17, 2019
Merged

hiranya911 merged 1 commit into
masterfrom
hkj-remove-changelog

Conversation

@hiranya911

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread prepare_release.sh
mv TEMP_CHANGELOG.md CHANGELOG.md
git add CHANGELOG.md
git commit -m "Updating CHANGELOG for ${VERSION} release."
git push origin ${RELEASE_BRANCH}

@lahirumaramba lahirumaramba Oct 17, 2019 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no changes to push, do we still need to create a release branch?

TIMESTAMP=$(date +%s)
RELEASE_BRANCH="release-${TIMESTAMP}
echo "[INFO] Creating new release branch: ${RELEASE_BRANCH}"
git checkout -b ${RELEASE_BRANCH} master

@hiranya911 hiranya911 Oct 17, 2019 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maven release plugins make some automated commits. We don't want those changes to go into master branch directly.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Makes sense. Thanks!

@lahirumaramba lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiranya911
hiranya911 merged commit d79485d into master Oct 17, 2019
@hiranya911
hiranya911 deleted the hkj-remove-changelog branch October 17, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants