Skip to content

Update brotli support to use the brotlicffi package#1605

Merged
lovelydinosaur merged 3 commits into
masterfrom
brotlicffi
Apr 28, 2021
Merged

Update brotli support to use the brotlicffi package#1605
lovelydinosaur merged 3 commits into
masterfrom
brotlicffi

Conversation

@lovelydinosaur

Copy link
Copy Markdown
Contributor

The brotlipy package has been superseded by the brotlicffi package.

See #1604

@lovelydinosaur lovelydinosaur added the refactor Issues and PRs related to code refactoring label Apr 28, 2021
@lovelydinosaur lovelydinosaur merged commit 760af43 into master Apr 28, 2021
@lovelydinosaur lovelydinosaur deleted the brotlicffi branch April 28, 2021 09:09
@lovelydinosaur lovelydinosaur mentioned this pull request Apr 29, 2021
@GeekDuanLian

Copy link
Copy Markdown

Hey, please follow the instructions in the brotlicffi document to import:

try:
    import brotlicffi as brotli
except ImportError:
    import brotli

Because it is difficult to install brotlicffi on cygwin, but Brotli is easy (existing software package).
So on cygwin, only can use import brotli.

@GeekDuanLian

Copy link
Copy Markdown

I suggest that the way to install dependencies is also in accordance with the brotlicffi documentation:

install_requires=[
    "brotli; platform_python_implementation == 'CPython'",
    "brotlicffi; platform_python_implementation != 'CPython'"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Issues and PRs related to code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants