introduce http2_prior_knowledge option in httpx Client#1523
Closed
p1-alexandrevaney wants to merge 2 commits into
Closed
introduce http2_prior_knowledge option in httpx Client#1523p1-alexandrevaney wants to merge 2 commits into
p1-alexandrevaney wants to merge 2 commits into
Conversation
5b4e97d to
75e0b2a
Compare
Contributor
|
Okay, so... Really this kind of PR could do with discussion first, although that's on us to help guide that process. (Which we're gradually starting to do.) My initial thought on seeing this is that an API that adds |
4 tasks
Author
|
Hello 😄, Yes i agree that a boolean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to be used in conjuction with this httpcore PR.
It passes the
http2_prior_knowledgeoption to the httpx client, which passes it to the httpcoreAsyncConnectionPoolinstanciation.I also added it to the http config model, to make sure that the alpn selected protocols only contains
"h2"if the http2_prior_knowledge option is set to True.