Network errors on HTTP/2 should propagate across all streams.#440
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Network errors on HTTP/2 need to be handled a bit differently to HTTP/1.1, because there will often be multiple streams being handled on the same connection. Rather than simply raising the exception we should...
Falsefor any futureis_availablecalls to disallow further requests being queued on the connection.This closes https://github.com/encode/httpx/issues/1414 - where the observed behaviour was a disconnect, followed by
TooManyStreamsexceptions. Instead of continuing to queue up further requests behind the one request that resulted in a disconnect, we instead want to see the disconnect apply to all existing requests on that connection, as well as preventing any future requests from being queued up on it.Testing this out...
TooManyStreamsexceptions. No gradually one-by-one tricklingReadTimeoutexceptions.)