Repository navigation
Conversation
The Content trust overview warns that DCT is being retired and that notary.docker.io shuts down on December 8, 2026, but the five how-to pages under it don't. Copy the overview's warning to the top of each page, matching how the Autobuilds deprecation notice is repeated across its section. Closes docker#26286
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
dvdksn
requested review from
craig-osterhout
and
a balanced review from Copilot
November 19, 2026 11:00
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change adding DCT retirement warnings to all five trust how-to pages.
No open issues 🎉
What changed in this PR
Adds the existing Docker Content Trust (DCT) retirement warning to all five trust how-to pages, so readers arriving directly see it before following setup instructions. This addresses #26286 without changing the procedures.
Changes:
- Repeats the overview’s warning unchanged at the top of each page.
- States the December 8, 2026 shutdown date for
notary.docker.ioand links to the retirement guidance.
| File | Description |
|---|---|
content/manuals/engine/security/trust/trust_sandbox.md |
Adds the warning before sandbox setup instructions. |
content/manuals/engine/security/trust/trust_key_mng.md |
Adds the warning before key-management guidance. |
content/manuals/engine/security/trust/trust_delegation.md |
Adds the warning before delegation guidance. |
content/manuals/engine/security/trust/trust_automation.md |
Adds the warning before automation instructions. |
content/manuals/engine/security/trust/deploying_notary.md |
Adds the warning before self-hosted Notary deployment instructions. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Content trust overview warns that DCT is being retired and that
notary.docker.ioshuts down on December 8, 2026. The five how-to pages underit don't, so readers who land on them from search follow DCT setup steps
without seeing the notice.
This copies the overview's warning, unchanged, to the top of each page. It's
the same pattern as the Autobuilds deprecation (#24981), which repeats one
callout across every page in that section.
Related issues or tickets
Closes #26286
#26287 made the same change but was closed by its author before review.
Reviews
deploying_notary.mdcovers self-hosting Notary Server, so thenotary.docker.iosentence applies to it less directly. I kept the wordingidentical on all five pages; happy to adjust it for that page.
trust_sandbox.md, but only the front matter, so the twochanges don't overlap.
rumdl 0.2.49 and Vale 3.17.0 report nothing on the added lines.
AI disclosure: I used Claude Code to check the pages against
main, find theAutobuilds precedent, make the edit, run the linters, and draft this
description. I reviewed the diff and this text before posting.