Repository navigation
Conversation
… example Signed-off-by: Kamrul Hossain <engr.kamrul45@gmail.com>
Signed-off-by: Kamrul Hossain <engr.kamrul45@gmail.com>
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Go cross-compilation examples set
GOOSandGOARCHfromTARGETOSandTARGETARCH, but never setGOARM. When Go cross-compiles forarmwithoutGOARM, it defaults toGOARM=7, so anyone following the example forlinux/arm/v6publishes an ARMv7 binary under the arm/v6 label, which crashes on ARMv6 boards such as the Raspberry Pi Zero W.This adds the pre-defined
TARGETVARIANTbuild argument to both examples and passes it to Go asGOARM=${TARGETVARIANT#v}:content/manuals/build/building/multi-platform.md: step 3 text, the updated Dockerfile, and the diff tab.content/manuals/build/bake/targets.md: the artifact export Dockerfile and its closing note.GOARMis only read whenGOARCH=arm, so other platforms are unaffected.Related issues or tickets
Fixes #26674
Reviews