Skip to content

[29.x backport] cli/command: reduce uses of client/pkg/progress utilities - #7529

Open
vvoland wants to merge 1 commit into
docker:29.xfrom
vvoland:7520-29.x
Open

vvoland wants to merge 1 commit into
docker:29.xfrom
vvoland:7520-29.x

Conversation

@vvoland

@vvoland vvoland commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

Also suppress some unhandled errors

Summary

Release notes (optional)

A picture of a cute animal (not mandatory but encouraged)

Also suppress some unhandled errors

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit a9f5e8a)
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added this to the 29.10.1 milestone Nov 17, 2026
@vvoland vvoland self-assigned this Nov 17, 2026
@vvoland vvoland added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Nov 17, 2026

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/service/progress/progress.go 64.70% 6 Missing ⚠️
cli/command/swarm/progress/root_rotation.go 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants