Repository navigation
Bug: make_kwargs does not work for generator make #1350
Description
Bug Report
Description
If the make function is a generator, it calls the make function of the AutoPopulate class itself, which does not take make_kwargs as an argument. This results in the following error if one passes make_kwargs to their table that uses generators for make (make_fetch, make_compute, make_insert):
TypeError: AutoPopulate.make() got an unexpected keyword argument 'name_of_the_kw_arg'
Reproducibility
- DataJoint Version: 0.14.6
- Steps:
- Create a table that uses make generators with
make_fetch,make_compute, andmake_insert - Try passing in
make_kwargsto thepopulatefunction of that table.
- Create a table that uses make generators with
Expected Behavior
make_kwargs should be passed down to make_fetch.
I can make a PR for this bug if it is not intended behavior.
Activity
fix: Pass make_kwargs to make_fetch in tripartite pattern
fix: Pass make_kwargs to make_fetch in tripartite pattern
test: Add tests for make_kwargs with regular and tripartite make
dimitri-yatsenko commentedon Jan 30, 2026
Fix
This issue is being addressed in two PRs:
fix/make-kwargs-tripartite→pre/v0.14.7— for the legacy 0.14.x release linefix/make-kwargs-tripartite-master→master— for the upcoming 2.x release line (includes regression tests)Root cause: The
make()method signature only acceptedkey, somake_kwargspassed topopulate()were not forwarded tomake_fetch()in the tripartite pattern.Fix: Updated
make(self, key)→make(self, key, **kwargs)and forward kwargs tomake_fetch(key, **kwargs).Release 0.14.7
We are preparing v0.14.7 as the final maintenance release for the 0.14.x branch. This release will include this fix and other critical bug fixes for users who have not yet migrated to v2.0.
End-of-Life Notice
The 0.14.x branch will be end-of-life after this release. All future development will focus on the v2.x release line.
There will be no v0.15 release. The next major version after 0.14.x is v2.0, which includes significant architectural improvements including the new type system, object-augmented schema, and other features documented in the v2.0 release notes.
Users on 0.14.x are encouraged to plan their migration to v2.0.