Repository navigation
acc: remove engine-specific logic from the acceptance harness - #6938
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: aa27dad
6 interesting tests: 6 flaky
Top 16 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/tf-cleanup-acc-harness
branch
from
October 6, 2026 10:15
6b9349f to
b69c827
Compare
denik
force-pushed
the
denik/tf-cleanup-tf-only-refs
branch
from
October 6, 2026 10:15
4e9d99e to
8ab9370
Compare
The terraform engine is gone, so no test varies DATABRICKS_BUNDLE_ENGINE anymore. - Drop the engine-aware subset grouping and 10x direct weighting; subset selection now hashes over all variants. - Drop the EnvMatrix.DATABRICKS_BUNDLE_ENGINE = [] validation, the terraform CHECKPOINT_DISABLE env, and the DBR runner's engine ENVFILTER. - Gate eventual-consistency injection on INJECT_STALE_ON_DIRECT alone. This makes postgres_synced_tables/recreate_capped exercise the capped wait it was written for (its golden previously showed a successful recreate). - read_state.py/print_state.py: drop the terraform-engine branch; print_state.py decides on DMS recording from the state file, not the engine env var. - Make engine-conditional test assertions unconditional, drop the dead permissions direct-vs-terraform comparison, and the terraform-only exclusions in empty_string_dropped/gen_empty_config.py (fixture and goldens regenerated). - Update testing rules that described the two-engine matrix. Co-authored-by: Isaac <no-reply@databricks.com>
DryRunMigrationTelemetry is gone, so these keys are never emitted. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
marked this pull request as ready for review
October 6, 2026 13:02
denik
enabled auto-merge
October 6, 2026 13:02
denik
force-pushed
the
denik/tf-cleanup-acc-harness
branch
from
October 6, 2026 13:04
b69c827 to
aa27dad
Compare
janniklasrose
approved these changes
Oct 6, 2026
andreamatt
pushed a commit
to andreamatt/databricks-cli
that referenced
this pull request
Oct 9, 2026
…atabricks#6941) (databricks#6969) Re-applies databricks#6941. databricks#6938 put the `DATABRICKS_BUNDLE_ENGINE=direct` check back into `staleOnceEnabled`: its "leave the stale-read injection fix to databricks#6941" commit was rebased after databricks#6941 merged and reverted it. Nothing sets that variable any more, so the testserver's stale-read injection was off and `postgres_synced_tables/recreate_capped` again recorded a successful recreate instead of the capped-wait failure. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
No test varies
DATABRICKS_BUNDLE_ENGINEanymore, so remove what the harness and tests still do for the terraform engine:CHECKPOINT_DISABLE, and the DBR runner's engineENVFILTER.read_state.py/print_state.py: drop the terraform branch;print_state.pydecides from the state file, not the engine env var.direct_drymigratetelemetry filtering, and the terraform-only exclusions inempty_string_dropped(fixture regenerated).This pull request and its description were written by Isaac.