Repository navigation
bundle: delete terraform code paths that are unreachable after the engine removal - #6935
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 06287b5
Top 6 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
October 6, 2026 07:33
denik
force-pushed
the
denik/bundle-internal-tf-removal
branch
from
October 6, 2026 10:05
a30335c to
bcedda7
Compare
…gine removal Remove the terraform-engine-only validators, the terraform permission error extender, dry-run migration telemetry, process.go's terraform ID-loading, --plan/--select engine checks, the terraform branch of PushResourcesState, the engine-mismatch warning in PullResourcesState, migrate's engine: terraform PostInitFunc, the closed-StateDB guard in ResolveConfigAgainstState and the never-set TerraformStateSizeBytes field. Every command that reaches these paths has already migrated to the direct engine, and engine: terraform is rejected during initialization. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/tf-cleanup-dead-paths
branch
from
October 6, 2026 10:15
74b2a82 to
06287b5
Compare
janniklasrose
approved these changes
Oct 6, 2026
yiweidai-db
pushed a commit
to yiweidai-db/cli
that referenced
this pull request
Oct 6, 2026
## Changes After migration, phases always run on the direct engine. Drop the engine argument and its branches from deploy/destroy/plan phases, `PreDeployChecks`, `SecretScopeFixups`, `CheckRunningResource`, `CheckDashboardsModifiedRemotely` (moved to `bundle/deploy`) and `configsync.ExtractChanges`. bind/unbind and `apps import` pass the bundle resource group straight to `phases.Bind`/`Unbind` instead of round-tripping through Terraform resource names; `BindOptions` moves next to `phases.Bind`. The guards refusing bind/unbind on terraform state are kept. ## Tests Pure refactor, no golden changes. Stacked on databricks#6935. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Delete terraform-only code that can no longer run: every command reaching it has already migrated to the direct engine, and
engine: terraformis rejected during initialization.validate_direct_only_resources,validate_lifecycle_started,validate_cluster_libraries,validate_cascade_on_destroy.bundle/permissions/terraform_errors.go, dry-run migration telemetry, never-setTerraformStateSizeBytes.process.goterraform ID loading and the--plan/--selectengine errors; terraform branch ofPushResourcesState; engine-mismatch warning inPullResourcesState;deployment migrateengine check; closed-StateDB guard inResolveConfigAgainstState.Kept
config.Bundle.Terraform(users can still set it in YAML; removing it would add an unknown-field warning).Tests
No golden changes.
This pull request and its description were written by Isaac.