Repository navigation
acc: terraform resource-type references after auto-migration - #6930
Merged
Merged
Conversation
Replay a terraform deployment whose config references other resources by terraform field paths, then check that the direct engine resolves them to the deployed values after auto-migration: clean plan, no changes on deploy, resolved names in state. Co-authored-by: Isaac <no-reply@databricks.com>
…rect
Bundles referencing resources as ${databricks_<type>.<name>...} deployed on terraform, but the direct engine only supports terraform field paths inside ${resources.*}: plan and deploy fail, both directly and after auto-migration from a replayed terraform deployment.
Co-authored-by: Isaac <no-reply@databricks.com>
tf-path-references duplicates resource_deps/tf_path_renames and tf_resource_type_ref fails the same way as the migration test; validate is now part of the migration test. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 999c1d5
Top 6 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
October 5, 2026 18:39
denik
enabled auto-merge
October 5, 2026 18:50
janniklasrose
approved these changes
Oct 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
To record current behaviour. There was at least one user that used ${databricks_x..} reference.
Changes
Adds
migrate/auto/tf-resource-type-references: replay a terraform deployment whose job references its pipeline as${databricks_pipeline.src_pipeline.id}(fixture captured from a terraform deploy just before #6888, where terraform resolved it), then auto-migrate. The direct engine does not support terraform resource-type references (only terraform field paths inside${resources.*}, #5392):validatepasses, then plan and deploy fail withinvalid dependency. The test records this withmusterr, so bundles using this syntax are stuck after the terraform removal until it is supported or rejected with an actionable error.This pull request and its description were written by Isaac.