Skip to content

Require the Docker credential helper on PATH in auth docker host - #6880

Merged
yolocs merged 1 commit into
mainfrom
chen-shou_data/stack/chen-shou/docker-host-shim-check
Oct 1, 2026
Merged

yolocs merged 1 commit into
mainfrom
chen-shou_data/stack/chen-shou/docker-host-shim-check

Conversation

@yolocs

@yolocs yolocs commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🥞 Stacked PR (generated by git ns)

Use this link to review incremental changes.


Changes

Require docker-credential-databricks to be discoverable on PATH before auth docker host reports the helper as configured.

Why

A Docker config entry alone can report YES even when the helper is missing or outside PATH, so Docker authentication would fail.

Tests

  • Added regression coverage for missing, off-PATH, and available helpers; observed failures before the fix and passes afterward.
  • Docker credential/auth unit tests and host/configure acceptance tests pass.
  • Full unit suite passes with the existing TestQuickHandover failure passing on retry.
  • Formatting, full lint, and repository checks pass with Go 1.26.8 and Python 3.12.
  • Full acceptance suite passes: 5,435 tests, 6 skipped.

This PR was written with Codex.

@yolocs
yolocs requested a review from a team as a code owner September 30, 2026 01:30
@yolocs
yolocs requested a review from anton-107 September 30, 2026 01:30
@yolocs
yolocs marked this pull request as draft September 30, 2026 01:43
@yolocs
yolocs removed the request for review from anton-107 September 30, 2026 01:43
@yolocs
yolocs force-pushed the chen-shou_data/stack/chen-shou/docker-host-shim-check branch from f5d3e72 to 2d6317c Compare September 30, 2026 01:43
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: fa3719d

Run: 36933530452

Env 🔄​flaky ✅​pass 🙈​skip Time
✅​ aws linux 276 16 5:25
🔄​ aws windows 2 276 14 3:17
✅​ azure linux 275 16 5:38
✅​ azure windows 277 14 5:13
✅​ gcp linux 276 16 5:19
🔄​ gcp windows 1 277 14 3:56
Test Name aws windows gcp windows
🔄​ TestAccept ✅​p 🔄​f
🔄​ TestFsCpDirToDirFileNotOverwritten 🔄​f ✅​p
🔄​ TestFsCpDirToDirFileNotOverwritten/local_to_uc-volumes 🔄​f ✅​p
Top 4 slowest tests (at least 2 minutes):
duration env testname
5:10 azure windows TestAccept
4:13 azure linux TestAccept
4:00 aws linux TestAccept
3:59 gcp linux TestAccept

@yolocs
yolocs marked this pull request as ready for review September 30, 2026 20:54
@yolocs
yolocs force-pushed the chen-shou_data/stack/chen-shou/docker-host-shim-check branch from 2d6317c to fa3719d Compare October 1, 2026 22:10
@yolocs
yolocs requested a review from a team as a code owner October 1, 2026 22:10
@yolocs
yolocs added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit cd3b9d6 Oct 1, 2026
31 checks passed
@yolocs
yolocs deleted the chen-shou_data/stack/chen-shou/docker-host-shim-check branch October 1, 2026 22:58
deco-sdk-tagging Bot added a commit that referenced this pull request Oct 7, 2026
## Release v1.20.0

### Notable Changes

 * Remove the Terraform deployment engine. `bundle.engine: terraform` and `DATABRICKS_BUNDLE_ENGINE=terraform` now error, and a failed migration of existing Terraform state is reported as an error instead of falling back to Terraform. To keep deploying with Terraform, use Databricks CLI v1.19.x. ([#6888](#6888), [#6889](#6889))

### CLI

 * `databricks aitools install` now supports Kiro, installing Databricks agent skills into its skills directory. ([#6908](#6908))
 * Fixed `databricks api` corrupting integers larger than 2^53 (such as job and pipeline ids) — request bodies and responses now preserve them exactly. ([#6884](#6884))
 * Added `--auth-mode` and `--set <plugin>.<resourceKey>.authMode=obo|sp|both` to `databricks apps init` so AppKit resources can be accessed on behalf of the user, by the service principal, or both. The default stays service principal. ([#6886](#6886))
 * `databricks apps init` now requires a value for every field a service principal resource binding references, prompting for missing values in an interactive terminal and otherwise failing with the `--set` key to use, instead of creating a project with unset variables. ([#6903](#6903))
 * Add `databricks apps init --package-manager <npm|pnpm>` to select the package manager for Node.js templates. Infer the default quietly from template lockfiles and AppKit version, check prerequisites before creating files, and preserve template formatting and pnpm version pins. ([#6902](#6902))
 * Select npm or pnpm from `packageManager` declarations and lockfiles for `apps validate` and project validation during `apps deploy`. ([#6892](#6892))
 * Fix `auth docker host` reporting the credential helper as configured when its executable is missing from `PATH`. ([#6880](#6880))
 * Warn when the CLI binary was built more than 6 months ago and recommend updating. ([#6898](#6898))

### AI Runtime

 * Add an experimental rank-partitioned container images to AI Runtime jobs. ([#6841](#6841))
 * Support snapshot fields directly under `code_source` without requiring `type` or a nested `snapshot` block. ([#6927](#6927))
 * Map AIR priority and Unity Catalog image fields when converting run configurations to bundles. ([#6905](#6905))
 * Add workspace backend validation to `air run --dry-run`. ([#6934](#6934))

### Bundles

 * Warn that `bundle.terraform` is deprecated and has no effect since the Terraform deployment engine was removed. ([#6940](#6940))
 * Direct engine now detects and applies an explicitly configured zero-value boolean or float (e.g. `gcp_attributes.use_preemptible_executors: false`, `azure_attributes.spot_bid_max_price: 0`) added to a resource first deployed without the field, matching the existing handling of an explicit integer zero. ([#6882](#6882))
 * Fix `bundle deployment migrate` failing with "no such file or directory" when the Terraform state has no resources or the configuration no longer declares any of them. ([#6958](#6958))
 * `bundle run` and `pipelines run` now send the per-update `development` parameter for pipelines in development mode targets. Setting `development` on a pipeline is deprecated and now emits a warning; use `mode: development` instead. ([#6863](#6863))
 * Remove the hidden `bundle debug terraform` command. ([#6933](#6933))
 * Add support for `run_as.group_name` at the bundle and target levels for jobs and pipelines. ([#6676](#6676))
 * Fix recreating a secret scope that was deleted outside of the bundle with the direct deployment engine. ([#6970](#6970))
 * Accept title-case booleans (`True`/`False`, as rendered by Azure Pipelines) for boolean variables, and accept the same boolean strings (`yes`/`no`, `on`/`off`, ...) in Python bundles as in YAML. ([#6942](#6942))

### Dependency Updates

 * Bump `github.com/databricks/databricks-sdk-go` from v0.182.0 to v0.185.0. ([#6928](#6928))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants