Repository navigation
ssh: skip filesystem registration on serverless - #6856
Merged
Merged
Conversation
On serverless the tunnel server runs as a non-root user, and the CRI shim rejects non-root UIDs on the WSFS and UC-FUSE daemon ports. Every registration attempt and refresh tick failed, logging ~1,440 warnings per 24h and flooding the warn-only log buffer that `ssh connect` reads back. Gate registration on the existing --serverless option: on serverless, log one Info line and skip the self-lookup, current-user lookup, daemon PUTs and refresh loop. The bootstrap REPL's own registration already covers the server's descendants. Dedicated clusters are unchanged. Refs DECO-28664. Co-authored-by: Isaac <no-reply@databricks.com>
anton-107
requested review from
lennartkats-db,
louis-johnston-db,
rclarey and
rugpanov
September 28, 2026 07:25
Collaborator
Integration test reportCommit: 981e94d
Top 6 slowest tests (at least 2 minutes):
|
rclarey
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
On serverless, the SSH tunnel server no longer tries to register itself with the WSFS and UC-FUSE daemons. It logs one Info line at startup and skips the self-lookup, the current-user lookup, both daemon PUTs, and the one-minute refresh loop:
startFuseRegistration(ctx, client, serverless)ininternal/server/fuse.go. The existing registration block and its warning moved out ofRunwithout changes.Runnow calls the helper withopts.Serverless.ssh server --serverlesshelp text now says "Whether the server runs on serverless compute".fusepackage is unchanged.How
Runchanges at startup:Where filesystem access comes from, by compute type:
flowchart LR subgraph Dedicated R1[bootstrap REPL<br/>registers itself] --> S1[tunnel server] S1 -- registers own PID<br/>every 60s --> D1[WSFS / UC-FUSE] S1 --> SH1[SSH sessions<br/>keep access after REPL exits] end subgraph Serverless R2[bootstrap REPL<br/>registers as root] --> D2[WSFS / UC-FUSE] R2 --> S2[tunnel server<br/>skips registration] S2 --> SH2[SSH sessions<br/>covered as REPL descendants] S2 -. non-root UID refused<br/>SDR-3124 .-x D2 endWhy
Skipping costs nothing. The bootstrap REPL's own registration runs as root and already covers the tunnel server and its descendants, and the container is torn down 35–60s after the REPL exits. The skip depends on the compute type the client already passes to the server, not on the error, so re-enabling registration later is one deliberate change. The regression came from #6645.
No changelog fragment: the #6645 entry ships as written.
Tests
TestStartFuseRegistrationSkipsServerless. Any HTTP request fails it, which proves the current-user lookup is skipped. It checks that the skip line is logged and nothing at WARN or above. It touches neither/procnor the network, so it runs on Linux, macOS and Windows.go test ./experimental/ssh/...passes, exceptTestSSHServerBootstrap, which fails locally on Python 3.6. That failure existed before this change../task lint-qand./task wsare clean.This pull request and its description were written by Isaac.