Repository navigation
Don't sync test.toml and script as bundle files in acceptance tests - #6843
Merged
Merged
Conversation
The acceptance runner copied each test's test.toml into the test dir and wrote the merged entry-point script there too, so "bundle deploy"/"sync" picked both up as bundle sources -- uploading them to the workspace and inflating every "Files: N" count. Skip copying test.toml, and run the merged script from outputDir (a sibling of the bundle dir) with a leading `cd "$TEST_TMP_DIR"`, so relative paths still resolve against the bundle dir and $0 stays "script" (no temp path leaks into output). Drop the now-dead workarounds that only existed to hide these files (.gitignore / sync.exclude / Ignore entries in a few sync, immutable and validate tests), and regenerate the goldens. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: dd206aa
Top 6 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
September 25, 2026 11:00
denik
requested review from
a team,
jefferycheng1,
kanterov and
lennartkats-db
as code owners
September 25, 2026 11:00
andrewnester
approved these changes
Sep 25, 2026
test.toml is no longer copied into the test dir and out* files live outside the bundle root, so `exclude: ["out*", "test.toml"]` matched nothing. Remove it; the deploy still times out on file_to_upload.txt exactly as before. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The acceptance runner copied each test's
test.tomlinto the test dir and wrote the merged entry-pointscriptthere too, sobundle deploy/syncpicked both up as bundle sources — uploading them to the workspace and inflating everyFiles: Ncount.Skip copying
test.toml, and run the merged script fromoutputDir(a sibling of the bundle dir) with a leadingcd "$TEST_TMP_DIR", so relative paths still resolve against the bundle dir and$0staysscript. Drop the now-dead workarounds that only existed to hide these files (.gitignore/sync.exclude/Ignoreentries in a few sync, immutable and validate tests), and regenerate the goldens.Related: #6629
This pull request and its description were written by Isaac.