Repository navigation
acc: remove obsolete .gitignore churn workaround from 11 bundle tests - #6665
Merged
Merged
Conversation
Collaborator
Integration test reportCommit: 172b44c
Top 4 slowest tests (at least 2 minutes):
|
…ests These tests zeroed the bundle sync with a catch-all .gitignore to keep the flaky `Files: N uploaded` line stable. Since output.txt and out.requests.txt were moved out of the sync root (#6629), the remaining synced files are stable (written once), so the workaround is no longer needed. Remove it and let the deploy summary show the real, stable counts. Left in place: resource_deps/create_error (the .gitignore pins an injected 500 to jobs/create rather than the file upload) and volumes/uppercase-name (captures its own deploy output into a synced file, which re-uploads across deploys). Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/remove-gitignore-hacks
branch
from
September 14, 2026 10:07
172b44c to
9ef71c0
Compare
denik
marked this pull request as ready for review
September 14, 2026 10:09
denik
enabled auto-merge
September 14, 2026 10:10
janniklasrose
approved these changes
Sep 14, 2026
Collaborator
Integration test reportCommit: 28cebe4
310 interesting tests: 182 FAIL, 114 MISS, 6 flaky, 4 RECOVERED, 3 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
…#6665) Follow-up to #6629. Those tests used a catch-all `echo "*" > .gitignore` to zero the bundle sync and keep the flaky `Files: N uploaded` line stable. Now that `output.txt`/`out.requests.txt` live outside the sync root, the remaining synced files are written once and stable, so the workaround is obsolete — remove it and let the deploy summary show the real counts. Not touched: `resource_deps/create_error` (its `.gitignore` pins an injected 500 to `jobs/create` instead of the file upload) and `resources/volumes/uppercase-name` (it captures its own deploy output into a synced file that re-uploads across deploys). This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6629. Those tests used a catch-all
echo "*" > .gitignoreto zero the bundle sync and keep the flakyFiles: N uploadedline stable. Now thatoutput.txt/out.requests.txtlive outside the sync root, the remaining synced files are written once and stable, so the workaround is obsolete — remove it and let the deploy summary show the real counts.Not touched:
resource_deps/create_error(its.gitignorepins an injected 500 tojobs/createinstead of the file upload) andresources/volumes/uppercase-name(it captures its own deploy output into a synced file that re-uploads across deploys).This pull request and its description were written by Isaac.