Repository navigation
Add changelog fragment when bumping the Go toolchain - #6271
Merged
Merged
Conversation
Co-authored-by: Isaac
Co-authored-by: Isaac
pietern
enabled auto-merge
August 14, 2026 09:31
Collaborator
Integration test reportCommit: 03661bc
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 3 slowest tests (at least 2 minutes):
|
| TOOLCHAIN: ${{ steps.latest.outputs.toolchain }} | ||
| run: | | ||
| echo "Bump Go toolchain to ${TOOLCHAIN#go}." \ | ||
| > ".nextchanges/dependency-updates/go-toolchain-${TOOLCHAIN}.md" |
Member
There was a problem hiding this comment.
@denik and I had a chat and we want to start linting nextchanges fragments to require the PR link.
Can we add "Add changelog fragment" after "Create pull requests" so we can include the link?
Contributor
Author
There was a problem hiding this comment.
Done. The snippet in the workflow is speculative... we'll see if it works on the next bump.
Address review feedback: expand the PR link in the 1.26.6 fragment, and generate future fragments after the PR is created so they can reference the PR number. Co-authored-by: Isaac
Co-authored-by: Isaac
janniklasrose
approved these changes
Aug 14, 2026
janniklasrose
pushed a commit
that referenced
this pull request
Sep 15, 2026
The most recent Go toolchain bump (#6266) merged without a changelog entry, because the `bump-go-toolchain` workflow never emitted one and no one added it by hand. - Add the missing fragment for `go1.26.6`, with the PR link expanded. - Update the workflow to write a version-named fragment on every bump. The fragment is added as a follow-up commit after the PR is created, so it can reference the new PR number (`([#N](.../pull/N))`) — this is why it runs after `Create pull request` rather than before, and it keeps the entry ready for the planned lint that requires a PR link on fragments. This pull request and its description were written by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent Go toolchain bump (#6266) merged without a changelog entry, because the
bump-go-toolchainworkflow never emitted one and no one added it by hand.go1.26.6, with the PR link expanded.([#N](.../pull/N))) — this is why it runs afterCreate pull requestrather than before, and it keeps the entry ready for the planned lint that requires a PR link on fragments.This pull request and its description were written by Isaac.