Repository navigation
List postgres databases during Lakebase plugin selection, add option to ignore fields in bundles - #4634
Merged
Conversation
Collaborator
|
Commit: f2a56d7
16 interesting tests: 7 KNOWN, 7 SKIP, 2 flaky
Top 21 slowest tests (at least 2 minutes):
|
pkosiec
force-pushed
the
pkosiec/postgres-db-lister
branch
from
March 3, 2026 11:23
b31a392 to
c8c3c0d
Compare
pkosiec
force-pushed
the
pkosiec/postgres-db-lister
branch
from
March 5, 2026 13:40
7bd03bc to
e8ec949
Compare
pkosiec
marked this pull request as ready for review
March 5, 2026 13:41
calvarjorge
marked this pull request as draft
March 6, 2026 13:21
calvarjorge
marked this pull request as ready for review
March 6, 2026 13:21
calvarjorge
approved these changes
Mar 6, 2026
pkosiec
force-pushed
the
pkosiec/bump-go-sdk
branch
from
March 9, 2026 14:14
08a5e25 to
996e407
Compare
pkosiec
requested review from
andrewnester,
anton-107,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
March 9, 2026 14:14
Revert the description hint and Filtering(true/false) changes in promptFromListWithLabel and PromptForAppSelection, as these are addressed properly in PR #4603. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pkosiec
force-pushed
the
pkosiec/postgres-db-lister
branch
from
March 9, 2026 15:50
e8ec949 to
f2a56d7
Compare
MarioCadenas
approved these changes
Mar 9, 2026
denik
pushed a commit
that referenced
this pull request
May 20, 2026
…to ignore fields in bundles (#4634) ## Changes - List postgres databases during Lakebase plugin selection - Add "bundleIgnore" field to exclude it from `databricks.yml` file (for Lakebase, we need a `LAKEBASE_ENDPOINT` env that shouldn't be listed in the DAB) - Fix the prompt title See also databricks/appkit#132 Resolves https://databricks.atlassian.net/browse/LKB-10074 ## Testing Test it together with databricks/appkit#132 -> check it out for the latest template 1. Build the CLI (`make build`) 2. Run the `databricks apps init` command with custom template (locally cloned one) - replace the path: `DATABRICKS_APPKIT_TEMPLATE_PATH="/Users/pawel.kosiec/repositories/databricks-os/appkit/template" dbx apps init` 3. Select Lakebase 4. Select your project, branch and database 5. DO NOT deploy your app yet 6. Move to the `databricks.yml` - Remove the `resources.apps.app.resources` and all unused variables (`postgres_branch`, `postgres_database`). 7. Deploy the app with `databricks apps deploy` 8. Bind the Lakebase project to your App, click "Deploy" button again 9. App should connect to Lakebase successfully ## Demo https://github.com/user-attachments/assets/29091cc2-62e3-4ece-aa50-8570d48d79a5 --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
databricks.ymlfile (for Lakebase, we need aLAKEBASE_ENDPOINTenv that shouldn't be listed in the DAB)See also databricks/appkit#132
Resolves https://databricks.atlassian.net/browse/LKB-10074
Testing
Test it together with databricks/appkit#132 -> check it out for the latest template
make build)databricks apps initcommand with custom template (locally cloned one) - replace the path:DATABRICKS_APPKIT_TEMPLATE_PATH="/Users/pawel.kosiec/repositories/databricks-os/appkit/template" dbx apps initdatabricks.ymlresources.apps.app.resourcesand all unused variables (postgres_branch,postgres_database).databricks apps deployDemo
init-flow.mov