Repository navigation
feat: use plugin manifest - #4469
Merged
Merged
Conversation
MarioCadenas
temporarily deployed
to
test-trigger-is
February 9, 2026 12:10 — with 
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
plugin-registry-integration
branch
from
February 9, 2026 12:20
93e4484 to
06f41ee
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
February 9, 2026 12:21 — with
GitHub Actions
Inactive
Collaborator
|
Commit: 8acf592
35 interesting tests: 13 RECOVERED, 11 flaky, 10 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
MarioCadenas
force-pushed
the
plugin-registry-integration
branch
from
February 9, 2026 14:45
06f41ee to
11fb319
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
February 9, 2026 14:46 — with
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
February 10, 2026 17:36 — with
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
February 10, 2026 18:00 — with
GitHub Actions
Inactive
pkosiec
reviewed
Feb 11, 2026
MarioCadenas
temporarily deployed
to
test-trigger-is
February 11, 2026 16:09 — with
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
February 13, 2026 11:38 — with
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
February 13, 2026 13:52 — with
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
February 13, 2026 14:19 — with
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
February 13, 2026 14:56 — with
GitHub Actions
Inactive
MarioCadenas
marked this pull request as ready for review
February 13, 2026 15:00
pkosiec
approved these changes
Feb 13, 2026
pkosiec
left a comment
Member
There was a problem hiding this comment.
Overall LGTM - tested locally build CLI with https://github.com/databricks/appkit/pull/82/changes.
(that was a high level code review only, as there's a lot of detailed databricks.yml generator logic and resource listers)
Comment on lines
+917
to
+921
| // pluginOwnedPaths maps plugin names to directories they own. | ||
| // When a plugin is not selected, its owned paths are removed from the project. | ||
| var pluginOwnedPaths = map[string][]string{ | ||
| "analytics": {"config/queries"}, | ||
| } |
Member
There was a problem hiding this comment.
It would be awesome to specify that somewhere on the template side and not hardcode it on CLI side 🤔 maybe not for now but let's at least create a follow-up task to not forget about the behavior? WDYT?
(I believe we might need to change the paths in future if we wanted to run two separate analytics plugins, same with lakebase or so - so the path should contain plugin instance name or something like that?)
| "strings" | ||
| ) | ||
|
|
||
| const ManifestFileName = "appkit.plugins.json" |
Member
There was a problem hiding this comment.
Can we rename it to appkit.template.json or template.appkit.json or sth like that? 🙏 as this manifest is mainly template-focused
fjakobs
approved these changes
Feb 16, 2026
MarioCadenas
temporarily deployed
to
test-trigger-is
February 16, 2026 12:15 — with
GitHub Actions
Inactive
MarioCadenas
temporarily deployed
to
test-trigger-is
February 16, 2026 13:27 — with
GitHub Actions
Inactive
MarioCadenas
enabled auto-merge
February 16, 2026 13:29
MarioCadenas
force-pushed
the
plugin-registry-integration
branch
from
February 16, 2026 13:30
53032af to
8acf592
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
February 16, 2026 13:30 — with
GitHub Actions
Inactive
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
…y files after template rendering (#4549) ## Changes - Show setup notes for plugins which have such instructions (needed for Lakebase plugin temporarily) - Remove hardcoded paths for analytics plugin - this will be handled purely by Go templates in the template itself - Remove empty files and directories after template rendering - Setup listers for `postgres` resource - ~Run "postinit" npm command in context of template if it exists~ - reverted as we don't need it for now Those changes need to be synchronized with AppKit where we add the `templatePaths` property in the manifest. ## Why - We're introducing new plugins, and depending on them, we need to configure the dynamic template. The hardcoded solution is not scalable, as I pointed out here: #4469 (comment) See also https://databricks.atlassian.net/browse/LKB-9681 ## Screenshot <img width="1461" height="738" alt="image" src="https://github.com/user-attachments/assets/966f8f84-94a4-4d4a-856e-7f5cdc703a57" /> ## Demo (just the listers for future Lakebase plugin changes databricks/appkit#132) https://github.com/user-attachments/assets/c745baad-662b-4f82-b197-ed95fcb89ef7
denik
pushed a commit
that referenced
this pull request
May 20, 2026
## Changes <!-- Brief summary of your changes that is easy to understand --> - Replace the hardcoded features package with a manifest-driven system that reads appkit.plugins.json from templates, enabling templates to declaratively define their plugins, resources, and dependencies without CLI code changes - Add Helm-style --set flag (--set plugin.resourceKey.field=value) for non-interactive resource configuration, replacing the static --warehouse-id flag - Introduce interactive resource pickers for all 11 resource types (SQL warehouses, jobs, serving endpoints, secrets, databases, genie spaces, volumes, UC functions, UC connections, vector search indexes, experiments) with multi-step pickers for hierarchical resources (catalog → schema → volume/function, instance → database, scope → key) and back-navigation support ## Key design decisions - **resourceKey** is the unique identifier — not type. This allows multiple resources of the same type per plugin (e.g., two genie spaces with different keys) - **appResourceSpecs** data-driven map — Centralizes the mapping from manifest resource types to DABs YAML structure, eliminating per-type switch statements - Templates without appkit.plugins.json work gracefully — The app is created normally, just without resource configuration - **app** resource type is filtered out at runtime (with TODOs) until DABs supports it as an app resource --------- Co-authored-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
denik
pushed a commit
that referenced
this pull request
May 20, 2026
…y files after template rendering (#4549) ## Changes - Show setup notes for plugins which have such instructions (needed for Lakebase plugin temporarily) - Remove hardcoded paths for analytics plugin - this will be handled purely by Go templates in the template itself - Remove empty files and directories after template rendering - Setup listers for `postgres` resource - ~Run "postinit" npm command in context of template if it exists~ - reverted as we don't need it for now Those changes need to be synchronized with AppKit where we add the `templatePaths` property in the manifest. ## Why - We're introducing new plugins, and depending on them, we need to configure the dynamic template. The hardcoded solution is not scalable, as I pointed out here: #4469 (comment) See also https://databricks.atlassian.net/browse/LKB-9681 ## Screenshot <img width="1461" height="738" alt="image" src="https://github.com/user-attachments/assets/966f8f84-94a4-4d4a-856e-7f5cdc703a57" /> ## Demo (just the listers for future Lakebase plugin changes databricks/appkit#132) https://github.com/user-attachments/assets/c745baad-662b-4f82-b197-ed95fcb89ef7
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Key design decisions